PMM-12376 single inventory add endpoint #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2422 +/- ##
==========================================
+ Coverage 42.71% 42.80% +0.08%
==========================================
Files 384 384
Lines 48194 48227 +33
==========================================
+ Hits 20587 20642 +55
+ Misses 25668 25640 -28
- Partials 1939 1945 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ademidoff
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
ademidoff
commented
Aug 21, 2023
Comment on lines
+109
to
+112
| func (s *nodesServer) AddNode(ctx context.Context, req *inventorypb.AddNodeRequest) (*inventorypb.AddNodeResponse, error) { | ||
| return s.svc.AddNode(ctx, req) | ||
| } | ||
|
|
There was a problem hiding this comment.
Minor: I think we can remove this file at all. Some time ago we agreed that these grpc packages are redundant.
There was a problem hiding this comment.
Ok, we should remove all the three in one shot IMO. Will do as a separate effort.
|
Also API tests are missing |
Thanks for pointing it out. Done now 🎉 |
artemgavrilov
approved these changes
Aug 28, 2023
Co-authored-by: Artem Gavrilov <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
BupycHuk
approved these changes
Aug 29, 2023
ademidoff
pushed a commit
that referenced
this pull request
Sep 16, 2023
* PMM-12376 add a single NodeAdd endpoint * PMM-12376 add a couple tests for AddNode * PMM-12376 add more tests * PMM-12376 remove debug lines * PMM-12376 format the code * PMM-12376 address linter errors * PMM-12376 pass context to transactions * PMM-12376 add more tests * PMM-12376 clean up the tests * PMM-12376 improve the tests * PMM-12376 re-generate the specs * PMM-12376 add AddNode to grpc server * PMM-12376 update the APi documentation * PMM-12376 update the documentation * PMM-12376 prefer oneof vs optional * PMM-12376 update the docs * PMM-12376 add API tests * PMM-12376 fix formatting * PMM-12376 fix API nodes_test * PMM-12376 fix API tests * PMM-12376 reindex message props in nodes.proto Co-authored-by: Artem Gavrilov <[email protected]> * PMM-12376 use NotEmpty for checking an array Co-authored-by: Artem Gavrilov <[email protected]> * PMM-12376 move back the api-tests/server tests * PMM-12376 running make gen * PMM-12376 replace NotZerof with NotEmptyf * PMM-12376 fix the TestContainerNode/Basic API test --------- Co-authored-by: Artem Gavrilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12376
Link to the Feature Build: SUBMODULES-3366
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
This is how the deprecation of endpoints looks like:
These are the endpoint params:
