PMM-12384 Backup artifact metrics #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2428 +/- ##
==========================================
- Coverage 42.76% 42.74% -0.03%
==========================================
Files 383 384 +1
Lines 48126 48188 +62
==========================================
+ Hits 20583 20597 +14
- Misses 25606 25656 +50
+ Partials 1937 1935 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
artemgavrilov
commented
Aug 23, 2023
Comment on lines
10
to
12
| description: |- | ||
| Failed to create backup artifact '{{ $labels.artifact_name}}' on service '{{ $labels.service_id }}'. | ||
| summary: Failed to create backup artifact '{{ $labels.artifact_name}}' on service '{{ $labels.service_id }}'. |
There was a problem hiding this comment.
TODO: Find better summary and description.
There was a problem hiding this comment.
@rnovikovP @catalinaadam any suggestions?
artemgavrilov
commented
Aug 24, 2023
artemgavrilov
requested review from
idoqo,
JiriCtvrtka and
BupycHuk
and removed request for
a team
ademidoff
reviewed
Aug 24, 2023
ademidoff
approved these changes
Aug 25, 2023
1 task
artemgavrilov
commented
Aug 29, 2023
idoqo
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12384
Link to the Feature Build: SUBMODULES-3370
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: