Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 fix bogus date in victoriametrcis.spec #2453

Merged
merged 9 commits into from
Sep 6, 2023

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Sep 1, 2023

PMM-7

Our agent tests suddenly started to fail when run with these matrix values:
mysql: 'percona:5.6', mongo: 'percona/percona-server-mongodb:4.2', postgres: 'perconalab/percona-distribution-postgresql:11', pg_libs: 'pg_stat_statements,pg_stat_monitor', pmm_server: 'percona/pmm-server:2'

Reference run: https://github.com/percona/pmm/actions/runs/6047924731/job/16412302430

The reason: the database client was not able to connect via IP6, failing with the error: dial tcp [::1]:5432: connect: connection refused.

This fix should address it.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2453 (aa2f526) into main (eea5256) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2453      +/-   ##
==========================================
- Coverage   42.80%   42.77%   -0.03%     
==========================================
  Files         383      383              
  Lines       48126    48126              
==========================================
- Hits        20601    20587      -14     
- Misses      25591    25602      +11     
- Partials     1934     1937       +3     
Flag Coverage Δ
admin 10.45% <ø> (+0.04%) ⬆️
agent 53.14% <ø> (-0.14%) ⬇️
managed 43.83% <ø> (-0.01%) ⬇️
vmproxy 69.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ademidoff ademidoff marked this pull request as ready for review September 1, 2023 14:37
@ademidoff ademidoff requested a review from a team as a code owner September 1, 2023 14:37
@ademidoff ademidoff requested review from idoqo, artemgavrilov and BupycHuk and removed request for a team September 1, 2023 14:37
@ademidoff ademidoff enabled auto-merge (squash) September 6, 2023 06:44
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, let's change the title

@ademidoff ademidoff merged commit f282fb2 into main Sep 6, 2023
@ademidoff ademidoff deleted the PMM-7-fix-pg-connection-issue-in-tests branch September 6, 2023 08:05
@ademidoff ademidoff changed the title PMM-7 fix postgresql connection issue in tests PMM-7 fix bogus date in victoriametrcis.spec Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants