Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "PMM-9769 update all components" #2463

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

talhabinrizwan
Copy link
Contributor

Reverts #2446

Following the merge of (#2446), we’ve encountered some CI failures, such as in this example: https://github.com/percona/pmm/actions/runs/6084707881/job/16507204096

TASK [Update system packages] **************************************************
fatal: [localhost]: FAILED! => {"changed": false, "failures": [], "msg": "Depsolve Error occurred: \n Problem: package ansible-5.4.0-2.el9.noarch requires (python3.9dist(ansible-core) >= 2.12.2 with python3.9dist(ansible-core) < 2.13), but none of the providers can be installed\n - cannot install both ansible-core-2.14.2-5.el9_2.x86_64 and ansible-core-2.12.2-2.el9_0.x86_64\n - cannot install both ansible-core-2.14.2-5.el9_2.x86_64 and ansible-core-2.12.2-1.el9.x86_64\n - cannot install the best update candidate for package ansible-core-2.12.2-2.el9_0.x86_64\n - cannot install the best update candidate for package ansible-5.4.0-2.el9.noarch", "rc": 1, "results": []}

Initially, this problem arose when the security: yes option was removed from the Ansible task to update everything in update/ansible/playbook/tasks/update.yml:
yum:
name: ""
state: latest
security: yes
exclude:
- nginx

To resolve this issue, we switched to installing the ansible-core instead of the ansible package.

However, a new challenge has surfaced with the older images, such as percona/pmm-server:2 or percona/pmm-server:dev-latest, which have already been released. These images contain the ansible package instead of ansible-core. Consequently, when attempting to update these images, we encounter failures.

We need to devise a strategy for handling these older images.

@talhabinrizwan talhabinrizwan requested review from idoqo and artemgavrilov and removed request for a team September 5, 2023 14:15
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #2463 (62f3ea8) into main (3d65cad) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
- Coverage   42.80%   42.76%   -0.04%     
==========================================
  Files         383      383              
  Lines       48126    48126              
==========================================
- Hits        20601    20583      -18     
- Misses      25588    25608      +20     
+ Partials     1937     1935       -2     
Flag Coverage Δ
admin 10.41% <ø> (-0.05%) ⬇️
agent 53.12% <ø> (-0.16%) ⬇️
managed 43.83% <ø> (ø)
vmproxy 69.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BupycHuk BupycHuk merged commit d8a0224 into main Sep 5, 2023
32 checks passed
@BupycHuk BupycHuk deleted the revert-2446-PMM-9769-update-all-components branch September 5, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants