PMM-11714 Don't return an error if API key can't be created. #2469
Conversation
BupycHuk
requested review from
idoqo and
artemgavrilov
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #2469 +/- ##
==========================================
- Coverage 42.76% 42.71% -0.05%
==========================================
Files 391 391
Lines 49043 49173 +130
==========================================
+ Hits 20971 21005 +34
- Misses 26096 26189 +93
- Partials 1976 1979 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
| // get authorization from headers. | ||
| md, ok := metadata.FromIncomingContext(ctx) | ||
| if !ok { | ||
| msg := "Couldn't create Admin API Key: cannot get headers from metadata" |
There was a problem hiding this comment.
was curious - is there anything fatal that can happen if we can't generate the admin role api key? and is there anything the user can do in such a case?
There was a problem hiding this comment.
we discussed with GAS team and made decission that register shouldn't fail in case it's not possible to create an API key. So pmm-agent will keep using user credentials instead of API key.
Co-authored-by: Alex Tymchuk <[email protected]>
BupycHuk
changed the title
PMM-11714
Link to the Feature Build: SUBMODULES-3381
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: