Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12375 add database version to services #2488

Merged
merged 61 commits into from
Oct 24, 2023

Fix linter

635ea40
Select commit
Loading
Failed to load commit list.
Merged

PMM-12375 add database version to services #2488

Fix linter
635ea40
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 24, 2023 in 1s

42.68% (-0.18%) compared to be137c9

View this Pull Request on Codecov

42.68% (-0.18%) compared to be137c9

Details

Codecov Report

Merging #2488 (635ea40) into main (be137c9) will decrease coverage by 0.18%.
The diff coverage is 27.87%.

@@            Coverage Diff             @@
##             main    #2488      +/-   ##
==========================================
- Coverage   42.86%   42.68%   -0.18%     
==========================================
  Files         385      387       +2     
  Lines       48399    48778     +379     
==========================================
+ Hits        20746    20822      +76     
- Misses      25700    25988     +288     
- Partials     1953     1968      +15     
Files Coverage Δ
admin/commands/management/add.go 70.96% <ø> (ø)
admin/commands/management/add_mysql.go 24.21% <100.00%> (ø)
agent/connectionchecker/connection_checker.go 52.71% <ø> (+0.19%) ⬆️
managed/models/database.go 42.91% <ø> (ø)
managed/models/service_model.go 86.95% <ø> (ø)
managed/models/service_model_reform.go 96.00% <100.00%> (+0.16%) ⬆️
managed/services/management/service_mgmt.go 74.80% <100.00%> (+0.19%) ⬆️
agent/client/client.go 42.15% <50.00%> (-0.04%) ⬇️
agent/commands/run.go 0.00% <0.00%> (ø)
managed/services/agents/channel/channel.go 56.88% <33.33%> (-0.53%) ⬇️
... and 12 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more