PMM-7 fix UI upgrade #2491
Merged
PMM-7 fix UI upgrade #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
idoqo,
artemgavrilov and
ademidoff
and removed request for
a team
ademidoff
reviewed
Sep 19, 2023
| @@ -173,6 +173,6 @@ | |||
| state: absent | |||
| path: /usr/share/pmm-server/maintenance/maintenance.html | |||
| # We use current_version_file['failed'] because we don't want to run this on creating container | |||
| when: not ui_upgrade and current_version_file['failed'] == false | |||
| when: not ui_upgrade and current_version_file['failed'] == false and not pmm_current_version is version(pmm_image_version, '>=') | |||
There was a problem hiding this comment.
Suggested change
| when: not ui_upgrade and current_version_file['failed'] == false and not pmm_current_version is version(pmm_image_version, '>=') | |
| when: | |
| - not ui_upgrade | |
| - current_version_file['failed'] == false | |
| - not pmm_current_version is version(pmm_image_version, '>=') |
There was a problem hiding this comment.
Not crucial, but much better to read and comprehend
ademidoff
approved these changes
Sep 19, 2023
talhabinrizwan
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: