Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12460 PMM Dump integration #2493

Merged
merged 85 commits into from
Nov 23, 2023
Merged

PMM-12460 PMM Dump integration #2493

merged 85 commits into from
Nov 23, 2023

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Sep 19, 2023

PMM-12460

Link to the Feature Build: SUBMODULES-3407

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Attention: 478 lines in your changes are missing coverage. Please review.

Comparison is base (a067046) 42.78% compared to head (8ac82dc) 42.60%.

Files Patch % Lines
managed/services/management/dump/dump.go 0.00% 198 Missing ⚠️
managed/services/dump/dump.go 0.00% 178 Missing ⚠️
managed/models/dump_helpers.go 57.34% 51 Missing and 10 partials ⚠️
managed/models/dump_reform.go 78.89% 23 Missing ⚠️
managed/models/dump.go 54.54% 10 Missing ⚠️
managed/cmd/pmm-managed/main.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2493      +/-   ##
==========================================
- Coverage   42.78%   42.60%   -0.18%     
==========================================
  Files         391      396       +5     
  Lines       49282    49939     +657     
==========================================
+ Hits        21085    21279     +194     
- Misses      26217    26670     +453     
- Partials     1980     1990      +10     
Flag Coverage Δ
admin 10.43% <ø> (ø)
agent 53.60% <ø> (+0.13%) ⬆️
managed 43.25% <27.35%> (-0.31%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

managed/services/dump/dump.go Outdated Show resolved Hide resolved
managed/services/management/dump/dump.go Outdated Show resolved Hide resolved
@artemgavrilov artemgavrilov changed the title PMM-12460 PMM Dump API PMM-12460 PMM Dump integration Oct 16, 2023
@artemgavrilov artemgavrilov requested review from ademidoff, BupycHuk, idoqo and JiriCtvrtka and removed request for a team November 2, 2023 12:52
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest concern I see here that PMM dump doesn't support PMM with external DBs like VM and CH.

build/packages/rpm/server/SPECS/pmm-dump.spec Show resolved Hide resolved
api/managementpb/dump/dump.proto Outdated Show resolved Hide resolved
api/managementpb/dump/dump.proto Outdated Show resolved Hide resolved
managed/models/dump_helpers_test.go Outdated Show resolved Hide resolved
managed/services/dump/dump.go Show resolved Hide resolved
managed/services/dump/metrics.go Outdated Show resolved Hide resolved
@artemgavrilov artemgavrilov merged commit 5dd1d3c into main Nov 23, 2023
33 checks passed
@artemgavrilov artemgavrilov deleted the PMM-12460-pmm-dump branch November 23, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants