-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-12460 PMM Dump integration #2493
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2493 +/- ##
==========================================
- Coverage 42.78% 42.60% -0.18%
==========================================
Files 391 396 +5
Lines 49282 49939 +657
==========================================
+ Hits 21085 21279 +194
- Misses 26217 26670 +453
- Partials 1980 1990 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
15221e9
to
5bf94c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest concern I see here that PMM dump doesn't support PMM with external DBs like VM and CH.
PMM-12460
Link to the Feature Build: SUBMODULES-3407
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: