Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12251 Service accounts. #2516

Merged
merged 171 commits into from
Apr 1, 2024
Merged

PMM-12251 Service accounts. #2516

merged 171 commits into from
Apr 1, 2024

Conversation

JiriCtvrtka
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka commented Oct 2, 2023

PMM-12251

Link to the Feature Build: Percona-Lab/pmm-submodules#3403

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

managed/services/grafana/client.go Outdated Show resolved Hide resolved
managed/services/grafana/client.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 43.47%. Comparing base (848155a) to head (3ac6d7f).

Files Patch % Lines
agent/client/client.go 0.00% 10 Missing ⚠️
admin/commands/management/unregister.go 0.00% 8 Missing ⚠️
admin/commands/base/setup.go 0.00% 6 Missing ⚠️
agent/client/token_auth.go 0.00% 6 Missing ⚠️
agent/commands/clients.go 0.00% 6 Missing ⚠️
agent/commands/setup.go 0.00% 2 Missing ⚠️
agent/client/basic_auth.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2516      +/-   ##
==========================================
- Coverage   43.52%   43.47%   -0.06%     
==========================================
  Files         362      363       +1     
  Lines       42423    42342      -81     
==========================================
- Hits        18464    18407      -57     
+ Misses      22386    22366      -20     
+ Partials     1573     1569       -4     
Flag Coverage Δ
admin 11.58% <0.00%> (-0.02%) ⬇️
agent 53.12% <0.00%> (-0.22%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percona percona deleted a comment from github-actions bot Oct 9, 2023
@percona percona deleted a comment from github-actions bot Oct 9, 2023
managed/services/grafana/client.go Outdated Show resolved Hide resolved
managed/services/grafana/client.go Show resolved Hide resolved
managed/services/grafana/client_test.go Outdated Show resolved Hide resolved
@JiriCtvrtka JiriCtvrtka requested a review from ademidoff February 1, 2024 08:20
@JiriCtvrtka
Copy link
Contributor Author

After discussion with Alex I removed t.Parallel() from tests in api_tests/inventory/nodes_test.go because they were unstable.

api-tests/management/mongodb_test.go Outdated Show resolved Hide resolved
api-tests/management/mongodb_test.go Outdated Show resolved Hide resolved
api/managementpb/node.proto Outdated Show resolved Hide resolved
JiriCtvrtka and others added 16 commits February 14, 2024 14:28
Co-authored-by: Nurlan Moldomurov <[email protected]>
* PMM-12686 Authorization between server and client.

* PMM-12686 Tests.

* PMM-12686 Lint.

* PMM-12686 Comment fix.

* PMM-12686 New required permissions for Connect endpoint.

* PMM-12686 Apply suggestion.

* PMM-12686 Add unit test for authenticate method.

* PMM-12686 Format.

* PMM-12686 Part changes after review.

* PMM-12686 Unit tests for auth server.

* PMM-12686 Revert unnecessary changes anymore.

* PMM-12686 Dynamic names in auth test.

* PMM-12686 Skip check for pmm-server agent.

* PMM-12686 Better local auth check.

* PMM-12686 Local auth check.

* PMM-12686 Refactor.

* PMM-12686 Refactor.

* PMM-12686 Refactor.

* PMM-12686 Fix.

* Update managed/services/grafana/auth_server.go

Co-authored-by: Alex Demidoff <[email protected]>

* PMM-12686 Revert of some changes.

* PMM-12686 Another reverted changes.

* PMM-12686 Years in licence.

* PMM-12686 Missed parallel in one test case.

---------

Co-authored-by: Alex Demidoff <[email protected]>
@BupycHuk BupycHuk merged commit 3cb9f9f into v3 Apr 1, 2024
27 of 28 checks passed
@BupycHuk BupycHuk deleted the PMM-12251-service-accounts branch April 1, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants