PMM-8471 run nginx as non-root #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #2589 +/- ##
==========================================
- Coverage 43.42% 43.38% -0.04%
==========================================
Files 361 361
Lines 42323 42323
==========================================
- Hits 18378 18362 -16
- Misses 22396 22414 +18
+ Partials 1549 1547 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
requested review from
a team,
BupycHuk and
talhabinrizwan
as code owners
ademidoff
requested review from
artemgavrilov,
idoqo and
JiriCtvrtka
and removed request for
a team
ademidoff
commented
Nov 3, 2023
BupycHuk
reviewed
Nov 3, 2023
BupycHuk
approved these changes
Nov 9, 2023
artemgavrilov
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-8471
Link to the Feature Build: SUBMODULES-3432
Other PRs:
Note: This PR requires to refactor our tests to use the unprivileged ports, i.e. -p 80:8080 -p 443:8443. It's being addressed and done for the pipelines, but there could be more, for instance the all-mighty pmm-framework :)
FYI: @puneet0191 @yurkovychv @vyarosh