Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12284 Remove Alertmanager #2614

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Nov 10, 2023

PMM-12284

Link to the Feature Build: SUBMODULES-3444

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

@artemgavrilov artemgavrilov changed the base branch from main to v3 November 10, 2023 12:16
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3@5d570ea). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v3    #2614   +/-   ##
=====================================
  Coverage      ?   43.98%           
=====================================
  Files         ?      358           
  Lines         ?    41640           
  Branches      ?        0           
=====================================
  Hits          ?    18317           
  Misses        ?    21741           
  Partials      ?     1582           
Flag Coverage Δ
admin 10.47% <0.00%> (?)
vmproxy 68.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov artemgavrilov marked this pull request as ready for review November 10, 2023 14:07
@artemgavrilov artemgavrilov requested review from ademidoff and JiriCtvrtka and removed request for a team November 10, 2023 14:08
@artemgavrilov
Copy link
Contributor Author

Tests are failing because alermanager.log is still present in our dev-latest.

@artemgavrilov artemgavrilov merged commit b1a4941 into v3 Dec 5, 2023
26 of 28 checks passed
@artemgavrilov artemgavrilov deleted the PMM-12284-remove-alertmanager branch December 5, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants