PMM-12530 run supervisor as non root #2643
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #2643 +/- ##
==========================================
+ Coverage 43.30% 43.32% +0.01%
==========================================
Files 361 361
Lines 42323 42323
==========================================
+ Hits 18329 18337 +8
+ Misses 22447 22440 -7
+ Partials 1547 1546 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
force-pushed
the
PMM-12530-run-supervisor-as-non-root
branch
5 times, most recently
from
65d5f14 to
71e32c6
Compare
ademidoff
force-pushed
the
PMM-12530-run-supervisor-as-non-root
branch
from
eff2e66 to
b6acd98
Compare
ademidoff
force-pushed
the
PMM-12530-run-supervisor-as-non-root
branch
from
29cd3cc to
dbfa806
Compare
ademidoff
force-pushed
the
PMM-12530-run-supervisor-as-non-root
branch
from
ba3abef to
9958160
Compare
ademidoff
force-pushed
the
PMM-12530-run-supervisor-as-non-root
branch
from
9958160 to
f9ada73
Compare
| @@ -179,8 +179,8 @@ | |||
| } | |||
|
|
|||
| # Swagger UI | |||
| rewrite ^/swagger/swagger.json$ /swagger.json permanent; | |||
| rewrite ^(/swagger)/(.*)$ /swagger permanent; | |||
| rewrite ^/swagger/swagger.json$ $scheme://$http_host/swagger.json permanent; | |||
There was a problem hiding this comment.
nginx was trying to connect to port :8080 otherwise :)
| - name: Remove the default nginx config files | ||
| file: | ||
| path: /etc/nginx/*.default | ||
| path: "{{ item }}" |
There was a problem hiding this comment.
Ansible's file module doesn't work with patterns :|
ademidoff
force-pushed
the
PMM-12530-run-supervisor-as-non-root
branch
from
ff6bc21 to
769479a
Compare
| docker run --rm -v ${HOME}/.aws:/root/.aws -v `pwd`:/build -w /build hashicorp/packer:${PACKER_VERSION} \ | ||
| build -var 'pmm_client_repos=original testing' \ | ||
| -var 'pmm_client_repo_name=percona-testing-x86_64' \ | ||
| sed -i 's|become_method: su|become_method: sudo|g' ./roles/postgres/tasks/main.yml && \ |
There was a problem hiding this comment.
not related to PR: why do we need these seds? don't we have this kind of logic in ansible?
There was a problem hiding this comment.
nevermind, anyway it will be dropped
There was a problem hiding this comment.
I didn't much know what to do with the seds, so just ended up updating the paths.
We needed these seds because in AMI we have to use sudo instead of su.
Now it will be a totally different story, as you mentioned )
| check: ## Run required checkers and linters | ||
| ansible-playbook --syntax-check ansible/pmm-docker/update.yml | ||
| ansible-playbook --check ansible/pmm-docker/update.yml | ||
| ansible-lint ansible/pmm-docker/update.yml |
ademidoff
requested review from
artemgavrilov,
idoqo and
JiriCtvrtka
and removed request for
a team
PMM-12530
Link to the Feature Build: SUBMODULES-3462
With this PR we:
/build/ansibledirectory located in the root of this repopmmuser (it has a number of implications, we'll detail them in the documentation when releasing)