Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12693 run grafana as non root #2648

Merged
merged 37 commits into from
Dec 4, 2023
Merged

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Nov 27, 2023

PMM-12693

Link to the Feature Build: SUBMODULES-3465

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b250e6) 44.11% compared to head (8d9ac7e) 44.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2648      +/-   ##
==========================================
- Coverage   44.11%   44.08%   -0.04%     
==========================================
  Files         358      358              
  Lines       42014    42014              
==========================================
- Hits        18535    18521      -14     
- Misses      21884    21898      +14     
  Partials     1595     1595              
Flag Coverage Δ
admin 10.47% <ø> (ø)
agent 53.47% <ø> (-0.14%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review November 30, 2023 00:18
@ademidoff ademidoff removed the request for review from a team November 30, 2023 00:18
@ademidoff ademidoff force-pushed the PMM-12693-run-grafana-as-non-root branch from 6a02810 to 60679c7 Compare December 1, 2023 11:49
@ademidoff ademidoff requested a review from a team as a code owner December 1, 2023 16:33
@ademidoff ademidoff requested review from artemgavrilov and removed request for a team December 1, 2023 16:33
@ademidoff ademidoff force-pushed the PMM-12693-run-grafana-as-non-root branch from 17cb6bc to 775b99d Compare December 4, 2023 10:40
@ademidoff ademidoff force-pushed the PMM-12693-run-grafana-as-non-root branch from 775b99d to 30f95c5 Compare December 4, 2023 10:40
@ademidoff ademidoff merged commit 5d570ea into v3 Dec 4, 2023
29 of 30 checks passed
@ademidoff ademidoff deleted the PMM-12693-run-grafana-as-non-root branch December 4, 2023 15:56
ademidoff added a commit that referenced this pull request Dec 4, 2023
* PMM-12693 Run grafana as non-root

* PMM-12693 rebuild grafana with new perms

* PMM-12693 remove sqlite migration

* PMM-12693 remove sqlite migration

* PMM-12693 revert some spec changes

* PMM-12693 check grafana logs

* PMM-12693 remove grafana-db-migrator

* PMM-12693 create grafana dir explicitly

* PMM-12693 fix with_items syntax

* PMM-12693 take ownership of /etc/grafana

* PMM-12693 try other options for /etc/grafana

* PMM-12693 try different permissions on /etc/grafana

* PMM-12693 remove grafana user

* PMM-12693 remove grafana user

* PMM-12693 set dir permissions for grafana-dashboards

* PMM-12693 do not install packages twice

* PMM-12693 remove CentOS 7 tasks

* PMM-12693 move grafana bootstrap to an earlier time

* PMM-12693 remove more CentOS 7 tasks

* PMM-12693 move clickhouse install back

* PMM-12693 do not upgrade sqlite

* PMM-12693 clean up the dashboards playbook

* PMM-12693 clean up the update playbook

* Update build/packages/rpm/server/SPECS/percona-dashboards.spec

Co-authored-by: Nurlan Moldomurov <[email protected]>

* PMM-12693 follow up on review

* PMM-12693 move the version copying out of dashboards_update

* PMM-12693 trigger the build

* PMM-12693 hackily start pmm-agent

* PMM-12693 check the status of services

* PMM-7 wait for container to get healthy

* PMM-7 debug: output grafana logs

* PMM-7 debug the ownership of /etc/grafana/grafana.ini

* PMM-7 change ownership of /etc/grafana to pmm

* PMM-7 change ownership of /srv/grafana to pmm

* PMM-7 cleanup the workflow

---------

Co-authored-by: Nurlan Moldomurov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants