PMM-7 cleanup docker-compose.yml for v3 #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #2667 +/- ##
==========================================
- Coverage 44.05% 44.05% -0.01%
==========================================
Files 358 358
Lines 41891 41891
==========================================
- Hits 18457 18455 -2
- Misses 21848 21850 +2
Partials 1586 1586
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
requested review from
idoqo,
JiriCtvrtka and
BupycHuk
and removed request for
a team
|
that was done for HA purpose and pmm-managed is supposed to start it. I would investigate that. |
Got it. I'll wait then for the results, since at least part of this PR needs to be merged. |
ademidoff
force-pushed
the
PMM-7-fix-agent-start
branch
from
eef379a to
a6ba535
Compare
ademidoff
force-pushed
the
PMM-7-fix-agent-start
branch
from
a6ba535 to
b08a443
Compare
BupycHuk
approved these changes
Dec 5, 2023
ademidoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7
This PR removes a few lines related to DBAAS, which are now redundant and which may have sneaked in during the last conflict resolution. It also contains a couple of other fixes.