Revert "PMM-8655 Send unsent messages after connection problems (#1970)" #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
ademidoff,
artemgavrilov and
JiriCtvrtka
and removed request for
a team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## pmm-2.41.0 #2676 +/- ##
==============================================
- Coverage 42.28% 42.12% -0.16%
==============================================
Files 399 395 -4
Lines 50339 49963 -376
==============================================
- Hits 21286 21048 -238
+ Misses 27061 26947 -114
+ Partials 1992 1968 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
approved these changes
Dec 5, 2023
JiriCtvrtka
approved these changes
Dec 5, 2023
agent/commands/run.go
Outdated
| @@ -113,9 +111,10 @@ func Run() { | |||
| func processClientUntilCancel(ctx context.Context, client *client.Client, reloadCh chan bool) { | |||
| for { | |||
| clientCtx, cancelClientCtx := context.WithCancel(ctx) | |||
| client.Run(clientCtx) | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of client.Run is not checked (errcheck)
| @@ -58,6 +59,18 @@ type versionsCache struct { | |||
| items map[string]*mySQLVersion | |||
| } | |||
|
|
|||
| func (m *PerfSchema) mySQLVersion() *mySQLVersion { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
func (*PerfSchema).mySQLVersion is unused (unused)
artemgavrilov
approved these changes
Dec 5, 2023
agent/client/client.go
Outdated
| } | ||
|
|
||
| func (c *Client) processChannelRequests(ctx context.Context) { | ||
| LOOP: | ||
| loop: |
There was a problem hiding this comment.
[go-consistent] reported by reviewdog 🐶
label case: use ALL_UPPER
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a3a52c1
PMM-12743
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: