Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-13001 Fix for PGSM switch in case of older versions. #2899

Merged
merged 3 commits into from
Mar 18, 2024
Merged

PMM-13001 Fix for PGSM switch in case of older versions. #2899

merged 3 commits into from
Mar 18, 2024

Conversation

JiriCtvrtka
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka commented Mar 14, 2024 •
edited
Loading

PMM-13001

Link to the Feature Build: Percona-Lab/pmm-submodules#3586

@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.24%. Comparing base (3545b3a) to head (7366084).
Report is 6 commits behind head on main.

Files Patch % Lines
managed/services/management/postgresql.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2899      +/-   ##
==========================================
- Coverage   42.26%   42.24%   -0.03%     
==========================================
  Files         396      396              
  Lines       50120    50120              
==========================================
- Hits        21184    21172      -12     
- Misses      26935    26945      +10     
- Partials     2001     2003       +2
Flag Coverage Δ
admin 11.60% <ø> (+0.04%) ⬆️
agent 53.20% <100.00%> (-0.14%) ⬇️
managed 42.80% <0.00%> (ø)
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review March 14, 2024 14:27
@JiriCtvrtka JiriCtvrtka requested review from BupycHuk and a team as code owners March 14, 2024 14:27
@JiriCtvrtka JiriCtvrtka requested review from ademidoff and idoqo and removed request for a team March 14, 2024 14:27
@JiriCtvrtka JiriCtvrtka mentioned this pull request Mar 14, 2024
Closed
1 task
@JiriCtvrtka JiriCtvrtka merged commit 5a7291d into main Mar 18, 2024
33 checks passed
@JiriCtvrtka JiriCtvrtka deleted the PMM-13001-PGSM-switch-compatibility branch March 18, 2024 08:41
JiriCtvrtka added a commit that referenced this pull request Mar 18, 2024
@JiriCtvrtka
PMM-13001 Fix for PGSM switch in case of older versions. (#2899)
157c16a 
* PMM-13001 Fix.

* PMM-13001 Fix test.

* PMM-13001 Change descriptor.
JiriCtvrtka added a commit that referenced this pull request Mar 18, 2024
@JiriCtvrtka
PMM-13001 Fix for PGSM switch in case of older versions. (#2899)
8e1d3d6 
* PMM-13001 Fix.

* PMM-13001 Fix test.

* PMM-13001 Change descriptor.
JiriCtvrtka added a commit that referenced this pull request Mar 18, 2024
@JiriCtvrtka
PMM-13001 Fix for PGSM switch in case of older versions. (#2899) (#2902)
39e2b52 
* PMM-13001 Fix.

* PMM-13001 Fix test.

* PMM-13001 Change descriptor.
ademidoff pushed a commit that referenced this pull request Mar 18, 2024
@JiriCtvrtka
PMM-13001 Fix for PGSM switch in case of older versions. (#2899) (#2903)
2eae13b 
* PMM-13001 Fix.

* PMM-13001 Fix test.

* PMM-13001 Change descriptor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BupycHuk BupycHuk BupycHuk approved these changes

@ademidoff ademidoff ademidoff approved these changes

@idoqo idoqo Awaiting requested review from idoqo idoqo is a code owner automatically assigned from percona/pmm-review-be

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JiriCtvrtka @ademidoff @BupycHuk