Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12899 Use module and build cache #2916

Draft
wants to merge 90 commits into
base: v3
Choose a base branch
from
Draft

PMM-12899 Use module and build cache #2916

wants to merge 90 commits into from

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Mar 21, 2024 •
edited
Loading

PMM-12899

Link to the Feature Build: SUBMODULES-3741

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.45%. Comparing base (8e92466) to head (45fd300).

Additional details and impacted files 
@@           Coverage Diff           @@
##               v3    #2916   +/-   ##
=======================================
  Coverage   43.44%   43.45%           
=======================================
  Files         360      360           
  Lines       43979    43979           
=======================================
+ Hits        19107    19109    +2     
+ Misses      23210    23208    -2     
  Partials     1662     1662
Flag Coverage Δ
admin 11.49% <ø> (+0.04%) ⬆️
agent 51.93% <ø> (ø)
managed 45.16% <ø> (ø)
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ademidoff
ademidoff commented Mar 21, 2024
View reviewed changes
.github/workflows/main.yml
SLACK_USERNAME: "PR pipelines bot"
SLACK_ICON_EMOJI: ":chestnut:"
SLACK_USERNAME: "Build bot"
SLACK_ICON_EMOJI: ":octocat:"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I couldn't resist - :octocat: seems to be much more to the point here :)

@ademidoff ademidoff mentioned this pull request Mar 21, 2024
Closed
@ademidoff ademidoff force-pushed the PMM-12899-use-module-and-build-cache branch from 0069c2d to 853be6e Compare March 21, 2024 04:12
ademidoff added 3 commits April 1, 2024 00:20
@ademidoff
PMM-12641 Fix the dashboard upgrade (#2926)
d57ec55 
* PMM-12641 Fix the dashboard upgrade

This fixes a bug where, due to a wrong ansible formula, PMM would upgrade the dashboards no matter what :)

* PMM-12641 follow up on review
@ademidoff
PMM-12899 prevent grafana from using own GOPATH
5c7821f
@ademidoff
PMM-12899 use a dedicated folder for yarn cache
42a02a9
@ademidoff ademidoff force-pushed the PMM-12899-use-module-and-build-cache branch from 8a0c440 to 42a02a9 Compare April 1, 2024 00:20
ademidoff added 17 commits April 1, 2024 01:19
@ademidoff
PMM-12899 extract server rpm script
6d0b02b
@ademidoff
Merge branch 'v3' into PMM-12899-use-module-and-build-cache
0a32c59
@ademidoff
PMM-12899 fix server param evaluation
098e894
@ademidoff
Merge branch 'PMM-12899-use-module-and-build-cache' of github.com:per…
c80fe45 
…cona/pmm into PMM-12899-use-module-and-build-cache
@ademidoff
PMM-12899 clean up server RPM specs
aa5729f
@ademidoff
PMM-12899 fix directory permissions
aa5e8b8
@ademidoff
PMM-12899 remove unnecessary macro
ee45fd6
@ademidoff
PMM-12899 revert QAN package name
afde65a
@ademidoff
PMM-12899 merge update.sh to build.sh
f28cbcc
@ademidoff
Merge branch 'v3' into PMM-12899-use-module-and-build-cache
66dc390
@ademidoff
PMM-12899 reorganize the script structure
093179a
@ademidoff
PMM-12899 get rid of exit 0 in callee scripts
12fd453
@ademidoff
PMM-12899 clean up pmm-update.spec
9587f21
@ademidoff
PMM-12899 send exec time to the log file
13b4f65
@ademidoff
PMM-12899 remove a redundant directory
6f9eac8
@ademidoff
PMM-12899 add total exec time
3eb50f8
@ademidoff
PMM-12899 reorg some variables
36869b7
@ademidoff
PMM-12899 clean up scripts
891a2f0
@ademidoff
PMM-12899 revert changes to grafana.spec
b193355
@ademidoff
PMM-12899 revert changes to grafana.spec
53de284
@ademidoff
PMM-12899 update goreleaser to latest
a7ebc00
@ademidoff
PMM-12899 use a different Go version for grafana
6ea7125
@ademidoff
PMM-12899 fix copying ansible files
f3b7ece
@ademidoff
PMM-12899 fix copying Dockerfile
3293ab5
@ademidoff
PMM-12899 fix legacy Docker label format
d501abc
@ademidoff
PMM-12899 do not use the repo subpaths for mutations
15be815
@ademidoff
PMM-12899 use a dedicated spec directory
eeccd8a
@ademidoff
PMM-12899 fix the spec directory evaluation
8c8bf03
@ademidoff
PMM-12899 create rpms directories first
4aa5012
@ademidoff
PMM-12899 fix find syntax
eaaeaf2
@ademidoff
PMM-12899 fix find syntax to search for both files and dirs
2325c53
@ademidoff
PMM-12899 revert changes made to grafana.spec
dc6cadd
@ademidoff
PMM-12899 try not to use cache for grafana
2819fc9
@ademidoff
PMM-12899 try not to use cache for grafana
cd0df5c
@ademidoff
PMM-12899 fix the cache directory not being writable
f5dc745
@ademidoff
PMM-12899 use no Go cache for grafana
a28edba
@ademidoff
PMM-12899 use no Go cache for grafana
44fc04b
@ademidoff
PMM-12899 remove docker tarballs
e1fbeca
@ademidoff
PMM-12899 add --client-only parameter
c94b549
@ademidoff
Merge branch 'v3' into PMM-12899-use-module-and-build-cache
687d3b6
@ademidoff
PMM-12899 rename build.sh to build
8944ef5
@ademidoff
PMM-12899 purge more files before starting
69899db
@ademidoff
PMM-12899 pass NO_VCS parameter to go build
a8756ab
@ademidoff ademidoff force-pushed the PMM-12899-use-module-and-build-cache branch from 03df05e to a8756ab Compare November 5, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BupycHuk BupycHuk Awaiting requested review from BupycHuk BupycHuk will be requested when the pull request is marked ready for review BupycHuk is a code owner

@talhabinrizwan talhabinrizwan Awaiting requested review from talhabinrizwan talhabinrizwan will be requested when the pull request is marked ready for review talhabinrizwan is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ademidoff