Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13082 Backwards compatibility with PMM v2 #3227

Merged
merged 16 commits into from
Nov 12, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Oct 8, 2024

PMM-13082

Link to the Feature Build: SUBMODULES-3730

api/agent/pb/agent.proto Show resolved Hide resolved
api/agent/pb/agent.proto Show resolved Hide resolved
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.53%. Comparing base (7852170) to head (c3e58b5).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
managed/services/agents/grpc/agentpb_server.go 0.00% 6 Missing ⚠️
managed/cmd/pmm-managed/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3227      +/-   ##
==========================================
- Coverage   43.54%   43.53%   -0.01%     
==========================================
  Files         365      366       +1     
  Lines       44151    44162      +11     
==========================================
+ Hits        19224    19228       +4     
- Misses      23245    23252       +7     
  Partials     1682     1682              
Flag Coverage Δ
admin 11.47% <ø> (ø)
agent 51.96% <ø> (ø)
managed 45.25% <46.15%> (-0.01%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percona percona deleted a comment from percona-robot Oct 8, 2024
@percona percona deleted a comment from percona-robot Oct 8, 2024
@percona percona deleted a comment from percona-robot Oct 8, 2024
api/agent/pb/agent.proto Show resolved Hide resolved
api/agent/pb/agent.proto Show resolved Hide resolved
api/agent/pb/agent.proto Show resolved Hide resolved
api/agent/pb/agent.proto Show resolved Hide resolved
api/agent/pb/agent.proto Show resolved Hide resolved
@ademidoff ademidoff changed the title PMM-13082 Backward compatibility with PMM v2 PMM-13082 Backwards compatibility with PMM v2 Oct 8, 2024
@ademidoff ademidoff force-pushed the PMM-13082-backward-compatibility-with-pmm-2 branch from f67e2c0 to 4b3373a Compare October 9, 2024 18:21
@@ -7,18 +7,28 @@ deps:
- buf.build/grpc-ecosystem/grpc-gateway
lint:
use:
- DEFAULT
- STANDARD
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: DEFAULT has become deprecated.

@ademidoff ademidoff marked this pull request as ready for review October 10, 2024 06:18
@ademidoff ademidoff requested review from BupycHuk and a team as code owners October 10, 2024 06:18
@ademidoff ademidoff requested review from idoqo and removed request for a team October 10, 2024 06:18
@ademidoff ademidoff requested a review from JiriCtvrtka October 10, 2024 06:18
@ademidoff ademidoff merged commit 6bfa326 into v3 Nov 12, 2024
32 checks passed
@ademidoff ademidoff deleted the PMM-13082-backward-compatibility-with-pmm-2 branch November 12, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants