PMM-13374 new mongodb fingerprints #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3271 +/- ##
==========================================
+ Coverage 43.62% 43.77% +0.15%
==========================================
Files 366 367 +1
Lines 44328 44497 +169
==========================================
+ Hits 19338 19479 +141
- Misses 23310 23332 +22
- Partials 1680 1686 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
JiriCtvrtka
reviewed
Feb 3, 2025
| @@ -328,7 +328,7 @@ func TestPerfSchema(t *testing.T) { | |||
| } | |||
|
|
|||
| default: | |||
| t.Log("Unhandled version, assuming dummy digests.") | |||
| t.Logf("Unhandled version, assuming dummy digests. MySQL version: %s, vendor: %s", mySQLVersion, mySQLVendor) | |||
There was a problem hiding this comment.
There is already log with vendor and version little bit above:
https://github.com/percona/pmm/pull/3271/files#diff-0b9b5d27ab40ea00095b446c95db2a4a7ef7c76d651c7f741b4e47789a0c6078R262
JiriCtvrtka
approved these changes
Feb 3, 2025
idoqo
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13374
Link to the Feature Build: SUBMODULES-3749
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: