Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13534: Use platform address for version service #3306

Merged
merged 13 commits into from
Nov 18, 2024
Merged

PMM-13534: Use platform address for version service #3306

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
be4dece
improve error handling for empty version list
idoqo Nov 14, 2024
b9a7062
drop unneeded check
idoqo Nov 14, 2024
c68b02e
Merge branch 'v3' into PMM-13534-consistent-env-vars
idoqo Nov 14, 2024
093a439
use debug messages and fix formatting
idoqo Nov 14, 2024
62d1d73
Allow nil in latest tests
idoqo Nov 14, 2024
9ba5a62
support staging and prod version lists
idoqo Nov 14, 2024
ed043e5
Merge branch 'v3' into PMM-13534-consistent-env-vars
ademidoff Nov 15, 2024
2e49115
update version URL
idoqo Nov 18, 2024
9cc0ee4
Merge branch 'v3' into PMM-13534-consistent-env-vars
BupycHuk Nov 18, 2024
ac25164
trigger rebuild
idoqo Nov 18, 2024
5f74f22
satisfy linter
idoqo Nov 18, 2024
57c5ad7
Merge branch 'v3' into PMM-13534-consistent-env-vars
idoqo Nov 18, 2024
c4284bc
fix tests
idoqo Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions managed/services/server/updater_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,10 @@ func TestUpdater(t *testing.T) {
u := NewUpdater(watchtowerURL, gRPCMessageMaxSize)
_, latest, err := u.latest(context.Background())
require.NoError(t, err)
assert.NotNil(t, latest)
assert.True(t, strings.HasPrefix(latest.Version.String(), "2.") || strings.HasPrefix(latest.Version.String(), "3."),
"latest version of PMM should have either a '2.' or '3.' prefix")
if latest != nil {
assert.True(t, strings.HasPrefix(latest.Version.String(), "2.") || strings.HasPrefix(latest.Version.String(), "3."),
"latest version of PMM should have either a '2.' or '3.' prefix")
}
})

t.Run("TestParseFile", func(t *testing.T) {
Expand Down
Loading