Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 Fix grafana stop/start #3320

Merged
merged 1 commit into from
Nov 19, 2024
Merged

PMM-7 Fix grafana stop/start #3320

merged 1 commit into from
Nov 19, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Nov 18, 2024

PMM-7

Link to the Feature Build: SUBMODULES-3773

  • Links to related pull requests (optional).

@ademidoff ademidoff changed the base branch from main to v3 November 18, 2024 20:04
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (7d61381) to head (0276306).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3320      +/-   ##
==========================================
+ Coverage   43.51%   43.53%   +0.02%     
==========================================
  Files         366      366              
  Lines       44169    44169              
==========================================
+ Hits        19219    19231      +12     
+ Misses      23265    23252      -13     
- Partials     1685     1686       +1     
Flag Coverage Δ
admin 11.51% <ø> (ø)
agent 51.96% <ø> (+0.12%) ⬆️
managed 45.24% <ø> (-0.01%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ademidoff ademidoff marked this pull request as ready for review November 19, 2024 06:31
@ademidoff ademidoff requested a review from a team as a code owner November 19, 2024 06:31
@ademidoff ademidoff requested review from BupycHuk and idoqo and removed request for a team November 19, 2024 06:31
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't ensure that grafana stops, because pmm-managed might start it any moment. But it's good enough for now.

@ademidoff
Copy link
Member Author

we can't ensure that grafana stops, because pmm-managed might start it any moment. But it's good enough for now.

Does pmm-managed launch grafana? I think it doesn't, it only generates grafana.ini config. Grafana's lifecycle is managed by supervisord only I believe.

@ademidoff ademidoff merged commit 45998f9 into v3 Nov 19, 2024
32 checks passed
@ademidoff ademidoff deleted the PMM-7-fix-grafana-stop-start branch November 19, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants