Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 Better grafana start/stop handler #3325

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Nov 20, 2024

PMM-7

Link to the Feature Build: SUBMODULES-3778

We are still seeing issues when we try to start grafana during the execution of the dashboards role. Reverting to stop/remove/add (as it was before) will hopefully fix it.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (82310f6) to head (a968931).
Report is 2 commits behind head on v3.

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #3325   +/-   ##
=======================================
  Coverage   43.53%   43.53%           
=======================================
  Files         366      366           
  Lines       44169    44169           
=======================================
  Hits        19231    19231           
  Misses      23252    23252           
  Partials     1686     1686           
Flag Coverage Δ
admin 11.51% <ø> (ø)
agent 51.96% <ø> (ø)
managed 45.24% <ø> (ø)
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ademidoff ademidoff marked this pull request as ready for review November 20, 2024 10:38
@ademidoff ademidoff requested a review from a team as a code owner November 20, 2024 10:38
@ademidoff ademidoff requested review from idoqo, JiriCtvrtka and talhabinrizwan and removed request for a team November 20, 2024 10:38
@ademidoff ademidoff merged commit dc1bbe8 into v3 Nov 20, 2024
32 checks passed
@ademidoff ademidoff deleted the PMM-7-better-start-stop-grafana-handler branch November 20, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants