-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-1901 metrics endpoint and collectors filtering. #23
base: main
Are you sure you want to change the base?
Conversation
Anton Kucherov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 83.71% 83.26% -0.46%
==========================================
Files 9 9
Lines 694 699 +5
==========================================
+ Hits 581 582 +1
- Misses 100 103 +3
- Partials 13 14 +1
Continue to review full report at Codecov.
|
@dexterHD pls click CLA button |
@AlekSi Please, check this out when you have a time. It's waiting for 2 weeks. |
rds_exporter is not used by PMM 2.0 beta6, so it is not a priority. That being said, if you want to do something about this PR, please think how to simplify factory.go. Code there looks overcomplicated for an apparently simple task. |
@rnovikovP @AlekSi But it's in PMM 2.0 beta6 release in JIRA 😕 As about complicated code, it's because of backward compatibility with the old endpoints. I'm not sure it worth to do something about that in the meaning of priorities. |
No description provided.