Skip to content

Commit

Permalink
Updated readme for chromium revision update (#1372)
Browse files Browse the repository at this point in the history
  • Loading branch information
chinmay-browserstack authored Oct 4, 2023
1 parent a9b7ebc commit 14503d0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 14 deletions.
16 changes: 3 additions & 13 deletions packages/core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -280,19 +280,9 @@ environment variable.

### How to update Chromium revision?

`src/install.js`

```js
chromium.revisions = {
linux: '.*',
win64: '.*',
win32: '.*',
darwin: '.*',
darwinArm: '.*'
};
```

Nicely summarised in this [stackoverflow](https://stackoverflow.com/a/56366776) answer.
- Vist https://chromiumdash.appspot.com/releases?platform=Mac and check for current version in use.
- Get Branch Base Position for that release.
- Visit https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/ and search for exact/neareast Branch Base Position.

### Excerpt

Expand Down
3 changes: 2 additions & 1 deletion scripts/chromium-revision.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/usr/bin/env node

// This is deprecated as it is not working for 115

const url = await import('url');
const path = await import('path');

Expand Down Expand Up @@ -124,7 +126,6 @@ async function printVersionRevisions(version) {

// no matching revision for this platform
if (!items) continue;

// check if the revision's commit is included in the desired release version
let sha = items[0].metadata['cr-git-commit'];
let tags = (await request(`${GH_TAGS_URL}/${sha}`, {}))
Expand Down

0 comments on commit 14503d0

Please sign in to comment.