✨ Upgrade to Node 12 (#161)

* 🔨 Upgrade to Node 12 * 👷 Run CI tests in Node 12 * ➖ Remove unneeded dependency Since eslint-standard 16, the plugin is no longer required * 🔨 Use Node 14 for development Specified with an .nvmrc file Release and Lint workflows were also updated to reflect a dev environment while the Test and Typecheck workflows are kept at Node 12 to test Maintenance LTS compatibility.
percy · Feb 2, 2021 · 269a07a · 269a07a
1 parent 4eca80b
commit 269a07a
Show file tree

Hide file tree

Showing 21 changed files with 560 additions and 527 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -8,14 +8,14 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 12
+          node-version: 14
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
       - uses: actions/cache@v2
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: v1/${{ runner.os }}/node-12/${{ hashFiles('**/yarn.lock') }}
-          restore-keys: v1/${{ runner.os }}/node-12/
+          key: v1/${{ runner.os }}/node-14/${{ hashFiles('**/yarn.lock') }}
+          restore-keys: v1/${{ runner.os }}/node-14/
       - run: yarn
       - run: yarn lint
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -9,7 +9,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: 12
+        node-version: 14
         registry-url: 'https://registry.npmjs.org'
     - run: yarn
     - run: yarn build

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -8,15 +8,15 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 10
+          node-version: 12
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
       - uses: actions/cache@v2
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: v1/${{ runner.os }}/node-10/${{ hashFiles('**/yarn.lock') }}
-          restore-keys: v1/${{ runner.os }}/node-10/
+          key: v1/${{ runner.os }}/node-12/${{ hashFiles('**/yarn.lock') }}
+          restore-keys: v1/${{ runner.os }}/node-12/
       - run: yarn
       - run: yarn build
       - uses: actions/upload-artifact@v2
@@ -30,7 +30,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node: [10]
+        node: [12]
         package:
           - '@percy/env'
           - '@percy/client'

diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+14
diff --git a/babel.config.js b/babel.config.js
@@ -2,7 +2,7 @@ module.exports = {
   presets: [
     ['@babel/env', {
       targets: {
-        node: '10'
+        node: '12'
       }
     }]
   ],

diff --git a/package.json b/package.json
@@ -32,7 +32,6 @@
     "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-promise": "^4.2.1",
-    "eslint-plugin-standard": "^5.0.0",
     "expect": "^26.4.2",
     "lerna": "^3.22.1",
     "mocha": "^8.1.3",

diff --git a/packages/cli-build/package.json b/packages/cli-build/package.json
@@ -7,6 +7,9 @@
     "dist",
     "oclif.manifest.json"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/cli-command/package.json b/packages/cli-command/package.json
@@ -8,6 +8,9 @@
     "dist",
     "types/index.d.ts"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/cli-config/package.json b/packages/cli-config/package.json
@@ -7,6 +7,9 @@
     "dist",
     "oclif.manifest.json"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/cli-exec/package.json b/packages/cli-exec/package.json
@@ -8,6 +8,9 @@
     "dist",
     "oclif.manifest.json"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/cli-snapshot/package.json b/packages/cli-snapshot/package.json
@@ -7,6 +7,9 @@
     "dist",
     "oclif.manifest.json"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/cli-upload/package.json b/packages/cli-upload/package.json
@@ -7,6 +7,9 @@
     "dist",
     "oclif.manifest.json"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -11,6 +11,9 @@
     "index.js",
     "oclif.manifest.json"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "lint": "eslint --ignore-path ../../.gitignore .",
     "postbuild": "oclif-dev manifest"

diff --git a/packages/client/package.json b/packages/client/package.json
@@ -7,6 +7,9 @@
     "dist",
     "test/helper.js"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/config/package.json b/packages/config/package.json
@@ -8,6 +8,9 @@
     "dist",
     "types/index.d.ts"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -9,6 +9,9 @@
     "types/index.d.ts",
     "test/helpers/server.js"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/dom/package.json b/packages/dom/package.json
@@ -6,6 +6,9 @@
   "files": [
     "dist"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "rollup --config",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/env/package.json b/packages/env/package.json
@@ -6,6 +6,9 @@
   "files": [
     "dist"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/logger/package.json b/packages/logger/package.json
@@ -7,6 +7,9 @@
     "dist",
     "test/helper.js"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "build": "babel --root-mode upward src --out-dir dist",
     "lint": "eslint --ignore-path ../../.gitignore .",

diff --git a/packages/sdk-utils/package.json b/packages/sdk-utils/package.json
@@ -7,6 +7,9 @@
     "index.js",
     "test/helper.js"
   ],
+  "engines": {
+    "node": ">=12"
+  },
   "scripts": {
     "lint": "eslint --ignore-path ../../.gitignore .",
     "test": "cross-env NODE_ENV=test mocha",