🧹 Clean up self reported client info

percy · Jul 31, 2020 · 29aef0a · 29aef0a
1 parent eb07c01
commit 29aef0a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/packages/cli-upload/src/commands/upload.js b/packages/cli-upload/src/commands/upload.js
@@ -7,6 +7,7 @@ import imageSize from 'image-size';
 import PercyClient from '@percy/client';
 import createImageResources from '../resources';
 import { schema } from '../config';
+import pkg from '../../package.json';
 
 const ALLOWED_IMAGE_TYPES = /\.(png|jpg|jpeg)$/i;
 
@@ -75,11 +76,14 @@ export class Upload extends Command {
 
     // we already have assets so we don't need asset discovery from @percy/core,
     // we can use @percy/client directly to send snapshots
-    this.client = new PercyClient();
+    this.client = new PercyClient({
+      clientInfo: `${pkg.name}/${pkg.version}`
+    });
+
     await this.client.createBuild();
-    log.info('Percy has started!');
+    let { build } = this.client;
 
-    let build = this.client.build;
+    log.info('Percy has started!');
     log.info(`Created build #${build.number}: ${build.url}`);
 
     for (let name of paths) {

diff --git a/packages/core/src/percy.js b/packages/core/src/percy.js
@@ -9,7 +9,6 @@ import Queue from './queue';
 import assert from './utils/assert';
 import { createRootResource, createLogResource } from './utils/resources';
 import { normalizeURL } from './utils/url';
-import pkg from '../package.json';
 
 // Register core config options
 PercyConfig.addSchema(schema);
@@ -66,11 +65,7 @@ export default class Percy {
       : PercyConfig.load({ path: config, overrides: options });
 
     this.discoverer = new Discoverer(this.config.discovery);
-    this.client = new PercyClient({
-      clientInfo: [`${pkg.name}/${pkg.version}`].concat(clientInfo),
-      environmentInfo,
-      token
-    });
+    this.client = new PercyClient({ token, clientInfo, environmentInfo });
   }
 
   // Shortcut for controlling the global logger's log level.