Skip to content

Commit

Permalink
Resolving comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rishigupta1599 committed Nov 23, 2023
1 parent 9207457 commit 2cc5aca
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion packages/core/src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ export function percyAutomateRequestHandler(req, percy) {
ignoreRegionSelectors: percy.config.snapshot.ignoreRegions?.ignoreRegionSelectors,
ignoreRegionXpaths: percy.config.snapshot.ignoreRegions?.ignoreRegionXpaths,
considerRegionSelectors: percy.config.snapshot.considerRegions?.considerRegionSelectors,
considerRegionXpaths: percy.config.snapshot.considerRegions?.considerRegionXpaths
considerRegionXpaths: percy.config.snapshot.considerRegions?.considerRegionXpaths,
version: 'v2'
},
camelCasedOptions
], (path, prev, next) => {
Expand Down
3 changes: 2 additions & 1 deletion packages/core/test/api.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ describe('API Server', () => {
percyCSS: '.global { color: blue }\n.percy-screenshot: { color: red }',
ignoreRegionSelectors: ['.selector-global'],
ignoreRegionXpaths: ['/xpath-per-screenshot'],
considerRegionXpaths: ['/xpath-global', '/xpath-per-screenshot']
considerRegionXpaths: ['/xpath-global', '/xpath-per-screenshot'],
version: 'v2'
}
}));

Expand Down
1 change: 0 additions & 1 deletion packages/webdriver-utils/src/providers/automateProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ export default class AutomateProvider extends GenericProvider {
if (!this.driver) throw new Error('Driver is null, please initialize driver with createDriver().');
log.debug('Starting actual screenshotting phase');
const dpr = await this.metaData.devicePixelRatio();
this.options.version = 'v2';
const response = await TimeIt.run('percyScreenshot:screenshot', async () => {
return await this.browserstackExecutor('percyScreenshot', {
state: 'screenshot',
Expand Down

0 comments on commit 2cc5aca

Please sign in to comment.