🐛 Fix config normalization and migration (#166)

* 🐛 Fix config key normalization

The previous regex was only matching the first occurrence of a dash or underscore. This new regex
will match even mixed sytaxes

* 🐛 Register core config migration for the migrate command

Since this command doesn't include core directly, core's config schema and migration are never
registered. We were already registering the schema, but also need to register the migration

* 🚚 Move core config registration to cli-exec

Core config registration is needed when running config:migrate, however cli-exec already requires
@percy/core but relies on the package to register itself. It makes more sense to require cli-exec do
the registration rather than have cli-config require core only for registration.

packages/cli-config/package.json

@@ -27,9 +27,6 @@
   "oclif": {
     "bin": "percy",
     "commands": "./dist/commands",
-    "hooks": {
-      "init": "./dist/hooks/init"
-    },
     "topics": {
       "config": {
         "description": "manage Percy config files"
@@ -40,7 +37,6 @@
     "@oclif/command": "^1.8.0",
     "@oclif/config": "^1.17.0",
     "@percy/config": "^1.0.0-beta.33",
-    "@percy/core": "^1.0.0-beta.33",
     "@percy/logger": "^1.0.0-beta.33"
   }
 }

packages/cli-exec/package.json

@@ -30,6 +30,9 @@
   "oclif": {
     "bin": "percy",
     "commands": "./dist/commands",
+    "hooks": {
+      "init": "./dist/hooks/init"
+    },
     "topics": {
       "exec": {
         "description": "capture and upload snapshots"

packages/cli-exec/src/hooks/init.js

@@ -0,0 +1,8 @@
+import PercyConfig from '@percy/config';
+import { schema, migration } from '@percy/core/dist/config';
+
+// ensures the core schema and migration is loaded
+export default function() {
+  PercyConfig.addSchema(schema);
+  PercyConfig.addMigration(migration);
+}

packages/config/src/normalize.js

@@ -8,10 +8,10 @@ const CAMELIZE_MAP = {
 };
 
 // Converts kebab-cased and snake_cased strings to camelCase.
-const KEBAB_SNAKE_REG = /(-|_)([^\1]+)/g;
+const KEBAB_SNAKE_REG = /[-_]([^-_]+)/g;
 
 function camelize(str) {
-  return str.replace(KEBAB_SNAKE_REG, (match, sep, word) => (
+  return str.replace(KEBAB_SNAKE_REG, (match, word) => (
     CAMELIZE_MAP[word] || (word[0].toUpperCase() + word.slice(1))
   ));
 }

packages/config/test/index.test.js

@@ -495,6 +495,31 @@ describe('PercyConfig', () => {
     });
   });
 
+  describe('.normalize()', () => {
+    it('removes empty values', () => {
+      expect(PercyConfig.normalize({
+        foo: 'bar',
+        arr: [{}, {}],
+        obj: { val: undefined },
+        nested: { arr: [undefined] }
+      })).toEqual({
+        foo: 'bar'
+      });
+    });
+
+    it('converts keys to camelCase', () => {
+      expect(PercyConfig.normalize({
+        'foo-bar': 'baz',
+        foo: { bar_baz: 'qux' },
+        'foo_bar-baz': 'qux'
+      })).toEqual({
+        fooBar: 'baz',
+        foo: { barBaz: 'qux' },
+        fooBarBaz: 'qux'
+      });
+    });
+  });
+
   describe('.stringify()', () => {
     it('formats the default config', () => {
       expect(PercyConfig.stringify('json')).toBe([