🐛 Ensure discoverer cleanup happens even when the page crashes

percy · Aug 4, 2020 · e9c57d1 · e9c57d1
1 parent 472460e
commit e9c57d1
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/packages/core/src/discoverer.js b/packages/core/src/discoverer.js
@@ -131,15 +131,17 @@ export default class PercyDiscoverer {
           meta
         }));
 
-      // navigate to the root URL and wait for the network to idle
-      await page.goto(rootUrl);
-      await idle(() => processing, this.networkIdleTimeout);
-
-      // cleanup
-      page.removeAllListeners('request');
-      page.removeAllListeners('requestfailed');
-      page.removeAllListeners('requestfinished');
-      await page.close();
+      try {
+        // navigate to the root URL and wait for the network to idle
+        await page.goto(rootUrl);
+        await idle(() => processing, this.networkIdleTimeout);
+      } finally {
+        // cleanup
+        page.removeAllListeners('request');
+        page.removeAllListeners('requestfailed');
+        page.removeAllListeners('requestfinished');
+        await page.close();
+      }
     });
   }