Capture service worker intercepted requests #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…re-service-worker-intercepted-requests
…re-service-worker-intercepted-requests
nilshah98
requested review from
prklm10 and
pankaj443
and removed request for
a team
itsjwala
reviewed
Nov 27, 2023
packages/core/src/discovery.js
Outdated
| @@ -288,6 +289,7 @@ export function createDiscoveryQueue(percy) { | |||
| requestHeaders: snapshot.discovery.requestHeaders, | |||
| authorization: snapshot.discovery.authorization, | |||
| userAgent: snapshot.discovery.userAgent, | |||
| captureServiceWorker: snapshot.discovery.captureServiceWorker, | |||
There was a problem hiding this comment.
per-snapshot level vs global config I'd commented in storybook PR. lets decide what to use and make it uniform.
There was a problem hiding this comment.
snapshot.discovery.captureServiceWorker will contain global value, can you verify once?
itsjwala
reviewed
Nov 27, 2023
packages/core/src/snapshot.js
Outdated
| @@ -114,6 +114,7 @@ function getSnapshotOptions(options, { config, meta }) { | |||
| requestHeaders: config.discovery.requestHeaders, | |||
| authorization: config.discovery.authorization, | |||
| disableCache: config.discovery.disableCache, | |||
| captureServiceWorker: config.discovery.captureServiceWorker, | |||
There was a problem hiding this comment.
okay we're overriding it here so no issues.
itsjwala
reviewed
Nov 27, 2023
The base branch for this one is https://github.com/percy/cli/tree/refactor-network-js. |
ninadbstack
reviewed
Nov 28, 2023
ninadbstack
approved these changes
Nov 28, 2023
itsjwala
pushed a commit
that referenced
this pull request
Nov 29, 2023
#1441) * feat: added defaultmap + locking mechanism for intercepts queue * feat: added checkResponseSent lock * chore: add comments + rename variables * refactor: move DefaultMap to core/utils * feat: track lifecycle for ALL requests, does not matter if nterwork is intercepted or not * feat: add locking mechanism for Network.loadingFailed and Network.eventSourceMessageReceived * refactor: lock names in requestLifeCycle * chore: lint fix * fix: coverage issue with single if blocks * test: added defaultMap specs * chore: remove unused intercepts map * Capture service worker intercepted requests (#1443) * feat: added new config discovery.captureServiceWorker * feat: use captureServiceWorker config to capture original requests * chore: lint fix * test: added spec for captureServiceWorker * chore: rename captureServiceWorker -> captureMockedServiceWorker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
captureMockedServiceWorkerflag underdiscoveryfor capturing service worker requestsbypass: falseforNetwork.setBypassServiceWorkerso that service-worker controller can be added and we can access the MSW mocks customer has added.serviceWorkerparameter, to handleRequests that are not intercepted (since service worker intercepted and will resolve them)Detailed Changes & Reasoning:
Network.setBypassServiceWorkertobypass: falseso that we can add service-worker controller and access service worker that mocks customer's data.Network.getResponseBody, but over herebodyis returned as""(empty string) randomly.Network.getResponseBodyon the original request which service-worker intercepted.Network.getResponseBodyis same as what appears in theResponsetab in Network section in devtools.Responsetab is always populated.body: ""whenNetwork.getResponseBodyis called on it.Network.getResponseBodyon the original request itself.Related PRs:
percy/percy-storybook#845