Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add captureServiceWorker flag when opening browser #845

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

nilshah98
Copy link
Contributor

@nilshah98 nilshah98 commented Nov 27, 2023

context -

  • we have added support for capturing service worker intercepted requests in Capture service worker intercepted requests cli#1443
  • in msw, it checks if service worker controller is registered or not. If it is not registered then it goes into an infinite rendering loop.
  • when using percy browser, by default we have setByPassServiceWorker: false which does not allow registration of service worker controller and hence we go in infinite rendering loop.
  • adding captureServiceWorker: true enables us to register service worker controller, and hence resolves the infinite rendering loop.

src/utils.js Outdated Show resolved Hide resolved
@nilshah98 nilshah98 merged commit 0dd53cb into master Nov 29, 2023
5 checks passed
@nilshah98 nilshah98 deleted the feat-enable-captureServiceWorker branch November 29, 2023 11:58
@itsjwala itsjwala added the ✨ enhancement New feature or request label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants