Percy on Automate: Making async create comparisons #1371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjwala
changed the title
itsjwala
reviewed
Sep 14, 2023
| @@ -118,8 +118,9 @@ export function createPercyServer(percy, port) { | |||
| })) | |||
| .route('post', '/percy/automateScreenshot', async (req, res) => { | |||
| req = percyAutomateRequestHandler(req, percy.build); | |||
| percy.upload(await new WebdriverUtils(req.body).automateScreenshot()); | |||
There was a problem hiding this comment.
check #1369
I've tried this, though this doesn't make it async, since we need to have a way to make that await removed which will require some more code changes. though this version is much simplified then what it is in master.
There was a problem hiding this comment.
Yes this is not full await however this unblocks PoA SDK. CLI can keep on waiting but if we add await which is master as of now that blocks the PoA. So if we have this thing then we do see speed improvements.
There was a problem hiding this comment.
you can close this PR, as I've updated this in the linked PR. (if the changes are same)
Also can you please review other bit in that PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Making upload comparisons async in order to attain better speed.