Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Added token support in percy config #1388

Merged
merged 1 commit into from
Oct 6, 2023
Merged

✨ Added token support in percy config #1388

merged 1 commit into from
Oct 6, 2023

Conversation

ninadbstack
Copy link
Contributor

@ninadbstack ninadbstack commented Oct 6, 2023 •
edited
Loading

  • Added support for token in percy config, under percy.token
  • PERCY_TOKEN env var would still override token from config

@ninadbstack ninadbstack requested a review from a team as a code owner October 6, 2023 05:49
@ninadbstack ninadbstack force-pushed the add_token_support_in_config branch from bc6674f to 6ffc497 Compare October 6, 2023 06:09
@ninadbstack ninadbstack force-pushed the add_token_support_in_config branch from 6ffc497 to c6f8751 Compare October 6, 2023 06:09
prklm10
prklm10 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@prklm10 prklm10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍 LGTM

@ninadbstack ninadbstack added the ✨ enhancement New feature or request label Oct 6, 2023
@ninadbstack ninadbstack merged commit c2788f8 into master Oct 6, 2023
35 of 36 checks passed
@ninadbstack ninadbstack deleted the add_token_support_in_config branch October 6, 2023 09:38
@renovate renovate bot mentioned this pull request Oct 19, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prklm10 prklm10 prklm10 approved these changes

@pankaj443 pankaj443 Awaiting requested review from pankaj443 pankaj443 is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninadbstack @prklm10