✨ Adding env variable support so that if set to true we exit with status code 0 when any percy related error occurs. #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it with status 0 on any percy error.
pankaj443
reviewed
Jul 2, 2024
| @@ -155,7 +159,10 @@ export function command(name, definition, callback) { | |||
| err.message ||= `EEXIT: ${err.exitCode}`; | |||
|
|
|||
| if (definition.exitOnError) { | |||
| process.exit(err.exitCode); | |||
| let shouldOverrideExitCode = err.shouldOverrideExitCode !== false; | |||
| let percyExitWithZeroOnError = process.env.PERCY_EXIT_WITH_ZERO_ON_ERROR === 'true'; | |||
There was a problem hiding this comment.
possible to remove duplication?
There was a problem hiding this comment.
I tried it but when setting const above the function the tests were failing.
pankaj443
approved these changes
Jul 2, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding env variable support so that if set to true we exit with status code 0 when any percy related error occurs.
PERCY_EXIT_WITH_ZERO_ON_ERRORis the env variable.It won't override when customer command throws any error.
This will solve #1590 issue.
Ticket -> https://browserstack.atlassian.net/browse/PER-3235