Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of issue id #1674, reporting false positive invalid config warning. #1675

Conversation

navrkald
Copy link
Contributor

@navrkald navrkald commented Jul 22, 2024

Validate presence of errors in config validator.

Fix: #1674

@navrkald navrkald requested a review from a team as a code owner July 22, 2024 11:29
@navrkald navrkald requested review from prklm10 and pankaj443 July 22, 2024 11:29
@navrkald navrkald force-pushed the bugfix/1674-fix-reporting-false-positive-invalid-config-warn branch from de24556 to 5949e83 Compare July 22, 2024 11:34
Copy link

github-actions bot commented Aug 6, 2024

This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label Aug 6, 2024
@sarah-gelt
Copy link

This false warning error is really annoying and easily fixed. Could it get a review please? 🙏

Copy link
Contributor

@pankaj443 pankaj443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the 🍞 stale Closed due to inactivity label Aug 13, 2024
@chinmay-browserstack chinmay-browserstack merged commit 0ffb62e into percy:master Aug 14, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Percy reports "Invalid snapshot options:" even when there is zero problems
4 participants