Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Added cookies support in direct requests #1764

Merged
merged 2 commits into from
Oct 23, 2024
Merged

✨ Added cookies support in direct requests #1764

merged 2 commits into from
Oct 23, 2024

Conversation

ninadbstack
Copy link
Contributor

Context:

  • We missed using cookies in the direct request done for woff2 font files
  • The request object coming with cdp does not contain cookie header - mostly its added later
  • So now we fetch correct cookies for url using cdp and use those cookies in direct request

@ninadbstack ninadbstack requested a review from a team as a code owner October 23, 2024 08:27
@ninadbstack ninadbstack force-pushed the cookies-in-direct-request branch from 4d925e0 to f6d447d Compare October 23, 2024 08:58
@ninadbstack ninadbstack force-pushed the cookies-in-direct-request branch from f6d447d to eff6096 Compare October 23, 2024 09:05
@ninadbstack ninadbstack merged commit 7cabfba into master Oct 23, 2024
36 checks passed
@ninadbstack ninadbstack deleted the cookies-in-direct-request branch October 23, 2024 11:38
@ninadbstack ninadbstack added the ✨ enhancement New feature or request label Oct 23, 2024
@ninadbstack ninadbstack changed the title Added cookies support in direct requests ✨ Added cookies support in direct requests Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmay-browserstack chinmay-browserstack chinmay-browserstack approved these changes

@prklm10 prklm10 prklm10 approved these changes

@pankaj443 pankaj443 Awaiting requested review from pankaj443 pankaj443 is a code owner automatically assigned from percy/percy-product-reviewers

@shantanuk-browserstack shantanuk-browserstack Awaiting requested review from shantanuk-browserstack shantanuk-browserstack is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ninadbstack @prklm10 @chinmay-browserstack