Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct CircleCI environment variable for pull request detection #1767

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

esetnik
Copy link
Contributor

@esetnik esetnik commented Oct 25, 2024

Copy link

This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label Nov 12, 2024
@esetnik
Copy link
Contributor Author

esetnik commented Nov 12, 2024

not stale

@github-actions github-actions bot removed the 🍞 stale Closed due to inactivity label Nov 19, 2024
@ninadbstack
Copy link
Contributor

ninadbstack commented Nov 26, 2024

@esetnik can you raise a support ticket as well for this ? In order to get this merged we will need to once go through the circle ci docs to see what all has changed and if there are any incompatibility issues on on self hosted older versions which will continue to need older env vars.

If everything looks good then we will get this merged!

@esetnik
Copy link
Contributor Author

esetnik commented Nov 28, 2024

@esetnik can you raise a support ticket as well for this ? In order to get this merged we will need to once go through the circle ci docs to see what all has changed and if there are any incompatibility issues on on self hosted older versions which will continue to need older env vars.

If everything looks good then we will get this merged!

I opened a support ticket and haven't heard back.

Copy link
Contributor

@pankaj443 pankaj443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked docs and confirmed updated env vars are valid

@ninadbstack
Copy link
Contributor

Added a newline [ basically blank commit ] to allow triggering workflows

@pankaj443 pankaj443 merged commit a42c13c into percy:master Dec 4, 2024
36 checks passed
@pankaj443
Copy link
Contributor

Hey @esetnik we have released v1.30.5-beta.1 with above changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants