Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAC file support via PERCY_PAC_FILE_URL env var #1784

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

khushhalm
Copy link

  • Added support for PAC file based Proxy

@khushhalm khushhalm requested a review from a team as a code owner November 19, 2024 05:43
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing specs

Copy link
Author

@khushhalm khushhalm Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I do this later? Can create a Jira so that this is not missed.
Need to share the custom build to GM by today to test PAC support.

Or if it blocker can I take help from someone in Percy team for this? Since need to test couple of other things.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we dont merge anything without specs on CLI - I can release alpha version from branch without specs if you want - so that its not merged to master

package.json Outdated Show resolved Hide resolved
@khushhalm khushhalm changed the title PAC file support via PERCY_PAC_FILE_PATH env var PAC file support via PERCY_PAC_FILE_URL env var Nov 19, 2024
@khushhalm khushhalm changed the base branch from master to pac-file-support November 19, 2024 08:02
@ninadbstack ninadbstack merged commit 5067675 into percy:pac-file-support Nov 19, 2024
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants