Adding sync params to screenshot call. #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prklm10
commented
Jan 23, 2024
prklm10
commented
- Adding sync params to screenshot call
- Timeout will be handled in CLI, will update the minimum version.
| } = {}) { | ||
| let response = null; | ||
| let error; | ||
| sync = sync || false; |
There was a problem hiding this comment.
Remove default value
There was a problem hiding this comment.
for app automate we can have default value right? Removing it and adding null.
| @@ -100,7 +102,8 @@ module.exports = async function percyScreenshot(driver, name, options = {}) { | |||
| scrollableXpath, | |||
| topScrollviewOffset, | |||
| bottomScrollviewOffset, | |||
| scrollableId | |||
| scrollableId, | |||
| sync | |||
There was a problem hiding this comment.
Add return statement inside percyOnAutomate function as well
fix: changed response.data -> response.body.data
Amit3200
approved these changes
Jan 30, 2024
shantanuk-browserstack
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.