Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable writing to .p4ticket during authentication. #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

earthling
Copy link

P4Java and the p4 command line tool both lock this file during updates. This can cause the scm plugin analysis to fail when analyses are conducted concurrently on the same machine (i.e., one or more may fail with permission denied errors). This pull request adds an option to disable writing to the tickets file.

@henryju
Copy link
Contributor

henryju commented Oct 7, 2016

We usually don't like adding configuration flags, so what about always skipping writing of ticket? Is there any reason to let the plugin write ticket?

@earthling
Copy link
Author

I can't see a reason for the sonar-scm-perforce plugin to write this file. It's really just a side effect of authenticating with p4java. I think in most scenarios, the .p4tickets file will have been created ahead of time when the source code is checked out for analysis (by p4 or p4v). I'll remove the option.

@earthling
Copy link
Author

For what it's worth, I've also been running this pull request in our environment. Haven't seen any issues.

@henryju henryju changed the title Add an option to disable writing to .p4ticket during authentication. Disable writing to .p4ticket during authentication. Oct 10, 2016
@henryju
Copy link
Contributor

henryju commented Oct 10, 2016

@earthling As you may know we moved this plugin under "SonarQubeCommunity" umbrella since we have not the (human) bandwidth at SonarSource to test Perforce. Your P/R look good to me but I will not test it. I could merge the P/R but I think it would be easier if you could take the lead on this plugin. Of course I will stay available for review if you want.
TL;DR would you accept to take the lead on this plugin?

@earthling
Copy link
Author

Sure, I will take the lead on this plugin.

@earthling
Copy link
Author

I don't have write permissions to this repo.

@henryju
Copy link
Contributor

henryju commented Oct 20, 2016

Sorry, I was also missing some permissions. You should now be able to commit. Feel free to update the pom.xml:

  • declare yourself as main developer
  • change organization

Once your changes are merged, if you want to release the plugin on SonarQube update center, please read: http://docs.sonarqube.org/display/DEV/Deploying+to+Update+Center

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants