Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only emit connection error messages during xread calls if the connect… #59

Merged
merged 3 commits into from
Jan 15, 2024
Merged

only emit connection error messages during xread calls if the connect… #59

merged 3 commits into from
Jan 15, 2024

Commits on Jan 15, 2024

  1. only emit connection error messages during xread calls if the connect… 

    …ion is supposed to be open

- this prevents the messages from being printed when a timeout occurs,
  which causes the connection to be closed and any pending xread calls
  to fail (when this happened users were confused into thinking that
  something has broken with roadblock instead of realizing it was a
  timeout issue)
    @k-rister
    k-rister committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    1a98506 View commit details
    Browse the repository at this point in the history

  2. set the return code as early as possible during a timeout 

    - this allows other parts of the code (which may be running in
  parallel) to see this as soon as possible
    @k-rister
    k-rister committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    d669f9e View commit details
    Browse the repository at this point in the history

  3. clear out the msgs array before each xread 

    - if the xread fails we want an empty array, not the previous arrays
  contents
    @k-rister
    k-rister committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    aac39a1 View commit details
    Browse the repository at this point in the history