Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OPAL Client Metrics Failure #761

Open
wants to merge 3 commits into
base: release/0.7.x
Choose a base branch
from

Conversation

psardana
Copy link
Contributor

…l-server and opal-client images to specific versions for stability

  1. change otel-collector port mapping from 8888 to 8889 to avoid conflicts
  2. add otel-collector to Prometheus scrape configuration for monitoring
  3. replace OpenTelemetry metrics with Prometheus Gauge for policy store status tracking and simplify metric update logic

Changes proposed

Check List (Check all the applicable boxes)

  • I sign off on contributing this submission to open-source
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

danyi1212 and others added 2 commits February 2, 2025 20:21
* Added hierarchical lock for applying data updates

* Added docs and inline comments

* Added _fetch_data to handle fetching errors

* Removed line reference

* Fixed test

* Fixed imports

* Fixed types for Python 3.9 support

* Removed TaskGroup use (python compat)

* Fixed import

* Fixed types

* Update packages/opal-client/opal_client/data/updater.py

Co-authored-by: Or Weis <[email protected]>

* Update packages/opal-client/opal_client/data/updater.py

Co-authored-by: Or Weis <[email protected]>

* Fixed pre-commit

---------

Co-authored-by: Or Weis <[email protected]>
…l-server and opal-client images to specific versions for stability

fix(docker-compose): change otel-collector port mapping from 8888 to 8889 to avoid conflicts
feat(prometheus): add otel-collector to Prometheus scrape configuration for monitoring
refactor(api.py): replace OpenTelemetry metrics with Prometheus Gauge for policy store status tracking and simplify metric update logic
Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit b81d584
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/67ae4266647780000872e67d

fix(otel-collector-config): update Prometheus exporter endpoint to 8889 for consistency with new configuration
@danyi1212 danyi1212 changed the base branch from master to release/0.7.x February 17, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants