Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUE files for panel plugins #11

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Nov 5, 2024

This PR:

  • Adds CUE files for all panel plugins. Copied from perses/perses at revision cdd8360987e5051ad056ffa506386fa0dbe4d4fd
  • Makes each plugin a standalone CUE module
    • Vendor/copy the common package dependency for each plugin
  • Copies also the plugins-specific doc

This is a first step of the plan I described here perses/perses#2085 (reply in thread)

Signed-off-by: Antoine THEBAUD <[email protected]>
@AntoineThebaud AntoineThebaud marked this pull request as ready for review November 5, 2024 15:39
@Nexucis
Copy link
Member

Nexucis commented Nov 7, 2024

I am wondering if we really want to version the vendor deps from perses/perses ? or instead having a sort of deps files and using the CLI it will install what is necessary ?

@AntoineThebaud
Copy link
Contributor Author

that's what I was thinking to do with my ongoing work on new percli commands, but let's say following the "legacy" modules & dep management of CUE this is how you should manage the deps "by the book":

cue.mod
|-- ...
|-- pkg         // copies of external packages
...

(from https://cuelang.org/docs/concept/modules-packages-instances/)

I like the idea to do a first PR that follows that, and then improve the situation incrementally (next step is using custom logic from Perses, final step would be to rely on the new dep management of CUE)

@Nexucis Nexucis merged commit b2c69b5 into main Nov 13, 2024
4 checks passed
@Nexucis Nexucis deleted the antoinethebaud/plugins-backend branch November 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants