add explorer plugins #37
Conversation
| }, | ||
| "peerDependencies": { | ||
| "@emotion/react": "^11.7.1", | ||
| "@emotion/styled": "^11.6.0", | ||
| "@hookform/resolvers": "^3.2.0", | ||
| "@perses-dev/components": "^0.50.1", | ||
| "@perses-dev/core": "^0.50.1", | ||
| "@perses-dev/dashboards": "^0.50.1", |
There was a problem hiding this comment.
I guess ideally explorer shouldn't be dependent on the package @perses-dev/dashboards that sounds heavy.
WDYT @jgbernalp @celian-garcia @Gladorme ?
There was a problem hiding this comment.
Yes is heavy. The main component used here is the Panel, which we might move to @perses-dev/components. I Just wanted to do minimal changes so this can work.
There was a problem hiding this comment.
For the moment this will be provided by Perses UI as a shared dependency
jgbernalp
force-pushed
the
add-explorer-plugins
branch
2 times, most recently
from
dc121e7 to
da4d146
Compare
|
While testing this, I found an issue. Here the fix perses/perses#2607 |
Prometheus/package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@perses-dev/prometheus", | |||
| "private": true, | |||
| "version": "0.4.1", | |||
| "version": "0.4.2", | |||
There was a problem hiding this comment.
| "version": "0.4.2", | |
| "version": "0.5.0", |
Because you are adding new functionalities, it's not a simple patch
Tempo/package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@perses-dev/tempo", | |||
| "private": true, | |||
| "version": "0.1.0", | |||
| "version": "0.1.1", | |||
There was a problem hiding this comment.
| "version": "0.1.1", | |
| "version": "0.2.0", |
same reason than for Prometheus, it's not a patch
Signed-off-by: Gabriel Bernal <[email protected]>
jgbernalp
force-pushed
the
add-explorer-plugins
branch
from
da4d146 to
a92ff6f
Compare
This PR:
Needs changes from Perses packages, in particular exports from
@perses-dev/exploreperses/perses#2598