Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add v10 upgrade to reduce blocksize #247

Merged
merged 1 commit into from
Oct 20, 2023
Merged

add v10 upgrade to reduce blocksize #247

merged 1 commit into from
Oct 20, 2023

Conversation

puneet2019
Copy link
Member

1. Overview

Reduce block size as per https://forum.cosmos.network/t/amulet-security-advisory-for-cometbft-asa-2023-002/11604/1
Currently it reduces by half to ~5mb, recommended is 2mb

Creating a PR so that it does not fall through the cracks.

2. Implementation details

add upgrade handler of v10

  • have not changed the app imports to v10 as it is not necessary as of now, that can be done when v10 is fully planned.

@puneet2019 puneet2019 requested a review from a team as a code owner October 18, 2023 07:08
@puneet2019 puneet2019 requested a review from xlab October 18, 2023 07:08
@kruspy
Copy link
Collaborator

kruspy commented Oct 20, 2023

Can we merge this ?

@puneet2019 puneet2019 merged commit 9e592d8 into main Oct 20, 2023
8 checks passed
@puneet2019 puneet2019 deleted the puneet/block_size branch October 20, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruspy kruspy kruspy approved these changes

@xlab xlab xlab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puneet2019 @kruspy @xlab