Exclude duplicate files for Run.Path and CodeCoverage.Path #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Deduplicate files if overlapping -Path values | ||
| $uniquePaths = [System.Collections.Generic.HashSet[string]]::new(@($files).Count) | ||
| $uniqueFiles = foreach ($f in $files) { if ($uniquePaths.Add($f.FullName)) { $f } } | ||
| Filter-Excluded -Files $uniqueFiles -ExcludePath $ExcludePath | & $SafeCommands['Where-Object'] { $_ } |
Check notice
Code scanning / PSScriptAnalyzer
The built-in *-Object-cmdlets are slow compared to alternatives in .NET. To fix a violation of this rule, consider using an alternative like foreach/for-keyword etc.`. Note
fflaten
commented
Jul 8, 2024
fflaten
commented
Jul 8, 2024
|
@nohwnd CI disabled in AzDO? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/backport to rel/5.6.x |
|
Started backporting to rel/5.6.x: https://github.com/pester/Pester/actions/runs/9879992903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Updates
Find-FileandGet-CodeCoverageFilePathsinternal functions to exclude duplicate files when provided overlappingPathvalues to search in. This affects:-Path / Run.Path-CodeCoverage / CodeCoverage.PathNew-PesterContainer -Path ..Data(parameters)PR also:
Get-CodeCoverageFilePathsto useGet-ChildItem -File -Recursefor increased performance.New-PesterContainerto avoid multiple filesystem searches when provided array of Data for increased performance.Fix #2530
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.