Fix Authentication by handing it over to garth #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the login dance and api calls, and fixes the broken login. Tokens are long-lived and can be stored, thus username and password are optional. The token store is currently hardcoded and insecure.
|
Thanks for showing an interest in the tool. I already turned down a PR to integrate with garth, and I still feel the same way about using a library that downloads credentials (whose?) from some S3 bucket. (see #104 (comment) for more details). I might reconsider but I would prefer another way, if possible. |
matin
reviewed
Mar 31, 2024
| @@ -268,8 +148,8 @@ def _fetch_activity_ids_and_ts(self, start_index, max_limit=100): | |||
| :rtype: tuples of (int, datetime) | |||
| """ | |||
| log.debug("fetching activities %d through %d ...", start_index, start_index + max_limit - 1) | |||
| response = self.session.get( | |||
| "https://connect.garmin.com/activitylist-service/activities/search/activities", | |||
| response = self.gc.get( | |||
There was a problem hiding this comment.
@flyingflo you can also use self.gc.connectapi()
drewbrew
reviewed
Dec 1, 2024
| response = self.session.get( | ||
| "https://connect.garmin.com/activitylist-service/activities/search/activities", | ||
| response = self.gc.get( | ||
| "connectapi", "/activitylist-service/activities/search/activities", api=True, |
There was a problem hiding this comment.
Some time between November 1 and today, this API call is now returning an empty list instead of my activity IDs (so I falsely have zero activities instead of almost a thousand)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #113
Use garth for auth and api
Replaces the login dance and api calls,
and fixes the broken login.
Tokens are long-lived and can be stored,
thus username and password are optional.
TODO: