Add possibility to remove timestamp in backup_name #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @peterrus , What do you think about that new feature? Thanks for your feedback |
peterrus
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Small nitpick but otherwise good to go, thanks for your contribution @webalexeu !
| @@ -20,7 +20,8 @@ The container is configured via a set of required environment variables: | |||
| - `S3_BUCKET_URL`: in most cases this should be `s3://name-of-your-bucket/` | |||
| - `AWS_DEFAULT_REGION`: The AWS region your bucket resides in | |||
| - `CRON_SCHEDULE`: Check out [crontab.guru](https://crontab.guru/) for some examples: | |||
| - `BACKUP_NAME`: A name to identify your backup among the other files in your bucket, it will be postfixed with the current timestamp (date and time) | |||
| - `BACKUP_NAME`: A name to identify your backup among the other files in your bucket | |||
| - `BACKUP_NAME_TIMESTAMP`: It will postfixed `BACKUP_NAME` with the current timestamp (date and time) (Optional, defaults to true) | |||
There was a problem hiding this comment.
Maybe rephrase this into "BACKUP_NAME will be postfixed with the current timestamp (etc)" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
PR proposal to be able to disable timestamp in backup name by setting BACKUP_NAME_TIMESTAMP = false
This is to be able to use versionning in S3 lifecycle policy
Thank you,
Alex