Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in amend_output(fit = NULL) fit is missing #41

Open
kellijohnson-NOAA opened this issue Apr 13, 2022 · 1 comment · May be fixed by #44
Open

Error in amend_output(fit = NULL) fit is missing #41

kellijohnson-NOAA opened this issue Apr 13, 2022 · 1 comment · May be fixed by #44
Assignees
@kellijohnson-NOAA
Labels
bug Something isn't working

Comments

@kellijohnson-NOAA
Copy link
Contributor

Need to pass the correct information to FishStatsUtils::plot_biomass_index()

https://github.com/nwfsc-assess/VASTWestCoast/blob/16194834f6258277a83969b66626ebf9664f756c/R/VAST_do.R#L144
@kellijohnson-NOAA kellijohnson-NOAA added the bug Something isn't working label Apr 13, 2022
@kellijohnson-NOAA kellijohnson-NOAA self-assigned this Apr 13, 2022
@James-Thorson-NOAA
Copy link

I'd be happy to help discuss these changes anytime too ... amend_output simplifies labelling and other logic that used to be dispersed among a bunch of plotting functions, but I realize it's always annoying to keep up with input/output changes like this.

@kellijohnson-NOAA kellijohnson-NOAA mentioned this issue Apr 14, 2022
Closed
kellijohnson-NOAA added a commit that referenced this issue Apr 15, 2022
@kellijohnson-NOAA
fix: Provides fit to FishStatsUtils::plot_biomass_index()
9d53f97 
if `fit = NULL` which is the default, then the function doesn't work.
This change provides the model output, which is labelled `out`,
to the `fit` input argument.

Closes #41
@kellijohnson-NOAA kellijohnson-NOAA linked a pull request Apr 15, 2022 that will close this issue
Draft
kellijohnson-NOAA added a commit that referenced this issue Apr 15, 2022
@kellijohnson-NOAA
fix: Provides fit to FishStatsUtils::plot_biomass_index()
6834506 
if `fit = NULL` which is the default, then the function doesn't work.
This change provides the model output, which is labelled `out`,
to the `fit` input argument.

Closes #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kellijohnson-NOAA kellijohnson-NOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 2022update pfmc-assessments/VASTWestCoast
2 participants
@kellijohnson-NOAA @James-Thorson-NOAA