Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gear grouping standards #69

Open
1 of 8 tasks
kellijohnson-NOAA opened this issue Nov 23, 2021 · 2 comments
Open
1 of 8 tasks

Gear grouping standards #69

kellijohnson-NOAA opened this issue Nov 23, 2021 · 2 comments
Labels
priority: low The lowest level priority, i.e., not urgent. status: in progress Currently working on this issue topic: code Related to R code within this package topic: documentation Related to documentation of code, methods, etc. type: enhancement
Milestone

Comments

@kellijohnson-NOAA
Copy link
Contributor

kellijohnson-NOAA commented Nov 23, 2021

Is your enhancement request related to a problem? Please describe.

For lingcod (2021) I grouped some catches from gill nets with the trawl fleet when they should of been part of the fixed gear fleet because they are a set net. Thanks to John Field for pointing this out.

Describe the solution you'd like

A programmatically created lookup table to translate gear codes to fleet and example code on how to use the table. The method should accommodate data from PacFIN, WCGOP, and RecFIN.

Tasks

References

WCGOP categories

  • Bottom trawl
  • Fixed gear
  • Hook and line
  • Midwater trawl
  • Pot
  • Shrimp trawl

Gear groupings

R code

@kellijohnson-NOAA kellijohnson-NOAA added type: enhancement status: question Questions about the issue need answered topic: code Related to R code within this package topic: documentation Related to documentation of code, methods, etc. labels Nov 23, 2021
@kellijohnson-NOAA kellijohnson-NOAA added this to the year_2022 milestone May 4, 2022
@kellijohnson-NOAA kellijohnson-NOAA added status: help wanted Help is needed status: in progress Currently working on this issue and removed status: question Questions about the issue need answered status: help wanted Help is needed labels May 10, 2022
@kellijohnson-NOAA kellijohnson-NOAA modified the milestones: year_2022, year_2023 May 8, 2023
@kellijohnson-NOAA kellijohnson-NOAA added the priority: low The lowest level priority, i.e., not urgent. label May 9, 2023
@kellijohnson-NOAA kellijohnson-NOAA modified the milestones: year_2023, year_2025 May 9, 2023
@iantaylor-NOAA
Copy link
Contributor

Here's a note on midwater trawl related to this issue.

The getGearGroup() function groups midwater trawl and bottom trawl in the TWL group with species-specific modifications to break it out for sablefish and spiny dogfish. Both use a MSC = miscellaneous group and spiny dogfish additionally separates midwater trawl from bottom trawl but lumps shrimp trawl with bottom trawl.

Widow Rockfish and Yellowtail Rockfish that are being assessed in 2025 are frequently caught by targeted midwater rockfish gear (Widow has a separate "midwater" fleet), so making it easy to explore the midwater catch separate from bottom trawl catch will be helpful.

@kellijohnson-NOAA you may have already covered this in your ongoing changes to this package, but it could be helpful to add to something to the README on gear groupings, perhaps including a suggestion to run something like dplyr::mutate(geargroup = ifelse(GRID == "MDT", yes = "MDT", no = geargroup)) to separate the midwater trawl for those who are interested.

Although the documentation makes it clear that the gear groupings come from https://pacfin.psmfc.org/pacfin_pub/data_rpts_pub/code_lists/gr.txt I don't understand how that information gets converted into the GearTable object used by getGearGroup(). Perhaps it's via get_codelist() but I don't see where that function is run, so some additional notes in the code might be helpful.

@kellijohnson-NOAA
Copy link
Contributor Author

In my recent edits that I am working on I have only fixed this for sablefish to create three groups.

If you follow the link in the previous comment, all GRID (which is what is present in the data downloaded from PacFIN) are translated to Gear Group and the gear groups are used for fleets. This will more than likely create too many fleets for what a user actually wants but it is at least a start. In the future it could be modified for more species behind the scenes but that is difficult because those methods are hidden from the average user so I have chosen to leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low The lowest level priority, i.e., not urgent. status: in progress Currently working on this issue topic: code Related to R code within this package topic: documentation Related to documentation of code, methods, etc. type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants